8000 [Upstream] [Util] LogAcceptCategory: use uint32_t rather than sets of strings by lyricidal · Pull Request #122 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Util] LogAcceptCategory: use uint32_t rather than sets of strings #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

[Upstream] [Util] LogAcceptCategory: use uint32_t rather than sets of strings #122

merged 1 commit into from
Sep 28, 2021

Conversation

lyricidal
Copy link

implemented on top of:

from bitcoin#9424

This changes the logging categories to boolean flags instead of strings.
This simplifies the acceptance testing by avoiding accessing a scoped static thread local pointer to a thread local set of strings. It eliminates the only use of boost::thread_specific_ptr outside of lockorder debugging.
This change allows log entries to be directed to multiple categories and makes it easy to change the logging flags at runtime (e.g. via an RPC, though that isn't done by this commit.)
It also eliminates the fDebug global.
Configuration of unknown logging categories now produces a warning.

We add 4 more debug categories:

  • BCLog::STAKING
  • BCLog::MASTERNODE (which includes previous "masternode" and "mnpayments" categories)
  • BCLog::MNBUDGET
  • BCLog::LEGACYZC

We remove BCLog::LEGACYZC and add BCLog::POA, BCLog::SUPPLY

PIVX-Project/PIVX#1437

@lyricidal lyricidal requested review from lopeed and anprdev September 28, 2021 20:29
@lopeed lopeed merged commit f56e69c into develop Sep 28, 2021
@lopeed lopeed deleted the upstream-LogAcceptCategory branch September 28, 2021 20:30
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed lopeed approved these changes

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0