8000 [Upstream] [DB] Bitcoin 0.12-0.14 dbwrapper improvements by lyricidal · Pull Request #102 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [DB] Bitcoin 0.12-0.14 dbwrapper improvements #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 27, 2021
Merged

[Upstream] [DB] Bitcoin 0.12-0.14 dbwrapper improvements #102

merged 13 commits into from
Aug 27, 2021

Conversation

lyricidal
Copy link

f4e6c52 from bitcoin/bitcoin#12659

The leveldb::Status class logs the filename of corrupted files, which might be useful when looking at error reports from usres. In theory this is already logged via the LogPrintf() statement in HandleError(), but that may not always be close to where the final error message is logged, e.g. see #11355 (comment) where the log trace provided by the user does not contain that information (and other user comments in the same issue).

This also adds a log message instructing the user to run the process with -debug=leveldb, which provides much more verbose error messages about LevelDB internals. This may not really help much, but improving the error messages here can't hurt.

The rest of the commits:

This backports a series of updates and cleanups to the LevelDB wrapper from:

PIVX-specific edits were required to keep the sporks and zerocoin databases in line.

[*] NOTE: excluding the obfuscation of databases by xoring data, as we might not want this feature (e.g. as zcash/zcash#2598). Otherwise it can be discussed, and added, with a separate PR.

from PIVX-Project/PIVX#1629

lyricidal added 13 commits August 24, 2021 12:36
@lyricidal
Log fatal LevelDB errors more verbosely
f4e6c52
@lyricidal
change hardcoded character constants to a set of descriptive named co…
be1c814 
…nstants for database keys

backports bitcoin/bitcoin@14d023f
@lyricidal
[DB] Refactor leveldbwrapper
1358bf4 
coming from bitcoin/bitcoin@42cb388 extracting the refactor and omitting the chainstate obfuscation
@lyricidal
Encapsulate CLevelDB iterators cleanly
1d5a53e 
based on bitcoin/bitcoin@3499ce1 and bitcoin/bitcoin@0fdf8c8 excluding the obfuscation, and fixing styling.
@lyricidal
Add tests for CLevelDBBatch, CLevelDBIteratorAdd tests for CLevelDBBa…
7e6cf75 
…tch, CLevelDBIterator

Backports bitcoin/bitcoin@1488506 (gettxoutsetinfo functional test is already ported)
@lyricidal
Fix chainstate serialized_size computation
10e6fd4 
backports bitcoin/bitcoin@298e040
@lyricidal
leveldbwrapper: Remove unused .Prev(), .SeekToLast() methods
2afb9da 
backports bitcoin/bitcoin@6ec4b7e
@lyricidal
leveldbwrapper symbol rename: Remove "Level" from class, etc. names
ac2226c 
backports bitcoin/bitcoin@8587b23
@lyricidal
leveldbwrapper file rename to dbwrapper.*
6d5687d 
backports bitcoin/bitcoin@3795e81
@lyricidal
dbwrapper: Move HandleError to dbwrapper_private
d5b5fda 
HandleError is implementation-specific.

backports bitcoin/bitcoin@869cf12
@lyricidal
Do not shadow members in dbwrapper
6d96883 
backports bitcoin/bitcoin@4a35e0f
@lyricidal
rpc: make gettxoutsettinfo run lock-free
8002947 
backports bitcoin/bitcoin@57092ed
@lyricidal
Refactor: Remove using namespace <xxx> from /dbwrapper_tests
c298206 
backports (partially) bitcoin/bitcoin@73f4119
@lyricidal lyricidal requested review from lopeed and anprdev August 27, 2021 02:04
@lopeed lopeed merged commit a769e60 into develop Aug 27, 2021
@lopeed lopeed deleted the upstream-backport_dbwrapper branch August 27, 2021 07:09
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed Awaiting requested review from lopeed

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0