8000 Update SMTP.php by Stevehans · Pull Request #3121 · PHPMailer/PHPMailer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update SMTP.php #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SMTP.php #3121

wants to merge 1 commit into from

Conversation

Stevehans
Copy link
@Stevehans Stevehans commented Dec 13, 2024 •
edited by Synchro
Loading

Resolves issue #2994

@Stevehans
Update SMTP.php
1db5a32 
Resolves issue 2994
@Stevehans
Copy link
Author

#2994

@Synchro
Copy link
Member
Synchro commented Dec 20, 2024

I think I've got a better idea for how to solve this. As I said in #2994, I suspect that this could happen during any command, not just DATA, so rather than having a flag purely for that command, I think a better approach would be (since SMTP is stateful) to have a state property that records what th 8000 e last command was. We can then use that the same way as you've done with the inData property to check the current state during shutdown. Thoughts?

@Sridhass
Copy link

@Synchro Have you added PHPMailerAutoload in this? Hope this might be helpful if added to this repo.
Thanks!

@Stevehans
Copy link
Author
Stevehans commented Dec 21, 2024 via email

@Synchro
Copy link
Member
Synchro commented Dec 21, 2024

@Synchro Have you added PHPMailerAutoload in this? Hope this might be helpful if added to this repo.

Thanks!

Why would I do that? PHPMailerAutoload is long dead; use composer.

64E1 Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stevehans @Synchro @Sridhass @anandfresh
0