8000 Correct type hints to prevent tooling like PHPStan from raising issues. by ldebrouwer · Pull Request #841 · PHP-DI/PHP-DI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Correct type hints to prevent tooling like PHPStan from raising issues. #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2023
Merged

Correct type hints to prevent tooling like PHPStan from raising issues. #841

merged 3 commits into from
Jan 9, 2023

Conversation

ldebrouwer
Copy link
Contributor

This PR allows people who use PHPStan in their tool chain to use named arguments when calling the method and constructor methods of CreateDefinitionHelper.

See #840

jdreesen
jdreesen reviewed Jan 9, 2023
View reviewed changes
ldebrouwer and others added 2 commits January 9, 2023 15:21
@ldebrouwer @jdreesen
Update src/Definition/Helper/CreateDefinitionHelper.php
6011611 
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
@ldebrouwer @jdreesen
Update src/Definition/Helper/CreateDefinitionHelper.php
7a17403 
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
@ldebrouwer
Copy link
Contributor Author

As per @jdreesen's suggestions I prefixed the hints with ... to denote that we're dealing with variadic functions/arguments.

@mnapoli
Copy link
Member
mnapoli 8000 commented Jan 9, 2023

Thanks!

@mnapoli mnapoli merged commit 6d9eab0 into PHP-DI:v7 Jan 9, 2023
@ldebrouwer ldebrouwer deleted the ldebrouwer/correct-type-hints branch January 9, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldebrouwer @mnapoli @jdreesen @ldebrouwer-rmn
0