Add @template return types for better autocomplete/static analysis #792
Conversation
|
Thank you! I have one question: does that PR still supports non-class-string parameters/returned values? Because yes, 90% of services are usually "class name -> class instance" mapping. But we don't want to break anything for services and values that are not indexed by a class name. Here's an example to illustrate: $container->set('foo', 'bar');
$abc = $container->get('foo');Will static analysis report any issue? |
|
That's a good point – in that case the return type union with Quick demo here, no errors on string/array and autocomplete on the object: |
|
Looks good, thank you for trying it out! Let's give this a try. If there's ever an issue that we did not anticipate, it will not be the kind of issue that will break production suddenly, so I'm fine with releasing now and iterate if needed. Thanks for the PR! |
PhpStorm now supports Psalm-style class string and template annotations (announcement). This works by default without needing to install or run Psalm on the project separately.
By adding template annotations to
get,makeandinjectOnmethods, we can get autocomplete without any inline docblocks or extra metadata files.I think by keeping the existing type annotations and just unioning the new template types, it should work fine with IDEs that don't support this syntax (note I haven't tested on any other IDEs).