[MRG] split ot.bregman #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
=======================================
Coverage 96.51% 96.52%
=======================================
Files 67 74 +7
Lines 14821 14859 +38
=======================================
+ Hits 14304 14342 +38
Misses 517 517 |
rflamary
reviewed
Nov 10, 2023
There was a problem hiding this comment.
that is great thanks @cedricvincentcuaz
A few more people to add at the top of the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Split
ot.bregman.pywithin a sub-repositoryot/bregman/containing files:ot.bregman.__init__.py._utils.py: maybe not necessary. For now it is used in_barycenter.pyand_dictionary.py. But it might be good for future integration, plus there are a lot of recurrent operations in this repository so it might be useful to factor it in the future.._barycenter.py._convolutional.py._empirical._screenkhorn._dictionaryMotivation and context / Related issue
Address request in Issue #567
How has this been tested (if it applies)
PR checklist