8000 fix: VoiceClient crashes while receiving audio by Hema2-official · Pull Request #2800 · Pycord-Development/pycord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: VoiceClient crashes while receiving audio #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

fix: VoiceClient crashes while receiving audio #2800

merged 4 commits into from
Jun 3, 2025

Conversation

Hema2-official
Copy link
Contributor
@Hema2-official Hema2-official commented Jun 3, 2025 •
edited by Lulalaby
Loading

Summary

I fixed issue #2644.
The problem was a length check taking place after byte checks.
I did extensive testing and it seems to completely get rid of the seemingly random crashes.
fixes: #2644

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Hema2-official
fix: VoiceClient crashes while receiving audio
2eb90d8 
Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com>
@Hema2-official Hema2-official requested a review from a team as a code owner June 3, 2025 14:45
@pullapprove4 pullapprove4 bot requested a review from BobDotCom June 3, 2025 14:45
Paillat-dev
Paillat-dev approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor
@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx for the fix

@Paillat-dev
Copy link
Contributor

@Hema2-official Please edit your message so that you have a line with the following format:

fixes: #2644

So that the pr is marked as fixing that issue

@Paillat-dev
Copy link
Contributor

image
Tf happened with readthedocs also, @Lulalaby can you try restarting that ?

@Paillat-dev
Copy link
Contributor
Paillat-dev commented Jun 3, 2025 •
edited
Loading

Also @Hema2-official add a changelog under Fixed please, take a look at CHANGELOG.md

@JustaSqu1d
Copy link
Member

image

Tf happened with readthedocs also, @Lulalaby can you try restarting that ?

Github died, i guess

@Lulalaby
Copy link
Member
Lulalaby commented Jun 3, 2025

build is re-running

@Lulalaby
Copy link
Member
Lulalaby commented Jun 3, 2025

fkng rtd

Lulalaby
Lulalaby requested changes Jun 3, 2025
View reviewed changes
Copy link
Member
@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking my approval - Changelog needed

@Lulalaby Lulalaby added bug Something isn't working priority: low Low Priority hold: changelog This pull request is missing a changelog entry labels Jun 3, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Pycord Releases Jun 3, 2025
@Lulalaby Lulalaby added this to the v2.7 milestone Jun 3, 2025
@Lulalaby
Copy link
Member
Lulalaby commented Jun 3, 2025 •
edited
Loading

We have to give up on the RTD CI for now. It seems like it doesn't report the status back anymore

Add the changelog @Hema2-official and we're good to go I'll bypass the reqs

@Paillat-dev
Copy link
Contributor

It just worked

@Lulalaby
Copy link
Member
Lulalaby commented Jun 3, 2025

I hate GitHub
hate

@Lulalaby Lulalaby removed the request for review from BobDotCom June 3, 2025 17:59
@Hema2-official
Copy link
Contributor Author

@Hema2-official Please edit your message so that you have a line with the following format:

Thanks for the edit, @Lulalaby 🫂

I'll add the changelog rq!

@Hema2-official
Update CHANGELOG.md
df1b0f7 
Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com>
@Hema2-official
Copy link
Contributor Author

Done, y'all can merge!
Thank you! <3

@Lulalaby Lulalaby enabled auto-merge (squash) June 3, 2025 18:37
@Lulalaby Lulalaby merged commit cd1531d into Pycord-Development:master Jun 3, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pycord Releases Jun 3, 2025
@Lulalaby Lulalaby removed the hold: changelog This pull request is missing a changelog entry label Jun 3, 2025
@Lulalaby Lulalaby linked an issue Jun 3, 2025 that may be closed by this pull request
"list index out of range" error when connecting to voice channel #2799
Closed
3 tasks
@siyukatu siyukatu mentioned this pull request Jun 21, 2025
Closed
3 tasks
VincentRPS pushed a commit to Pycord-Test/pycord that referenced this pull request Jun 28, 2025
@Paillat-dev @Lumabots
@NeloBlivion @pre-commit-ci @Hema2-official @Lulalaby @dependabot @DA-344 @Dorukyum @plun1331 @emmanuel-ferdman
chore: merge upstream repo (#37)
2078cef 
* fix: Role Edit TypeHint (Pycord-Development#2795)

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* fix: command syncing edge cases (Pycord-Development#2797)

* change default nsfw to false

* cl

* localizations

* :=

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: VoiceClient crashes while receiving audio (Pycord-Development#2800)


Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): bump typing-extensions from 4.13.1 to 4.13.2 in the patch-version-bumps group (Pycord-Development#2783)

chore(deps): bump typing-extensions in the patch-version-bumps group

Bumps the patch-version-bumps group with 1 update: [typing-extensions](https://github.com/python/typing_extensions).


Updates `typing-extensions` from 4.13.1 to 4.13.2
- [Release notes](https://github.com/python/typing_extensions/releases)
- [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
- [Commits](python/typing_extensions@4.13.1...4.13.2)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-version: 4.13.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch-version-bumps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add created_at property to Interaction (Pycord-Development#2801)

* feat: add created_at property to Interaction for message creation time

* Update CHANGELOG.md

* Update discord/interactions.py

Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>

---------

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>

* chore(deps): update setuptools requirement from <=78.1.0,>=62.6 to >=62.6,<=80.8.0 (Pycord-Development#2786)

chore(deps): update setuptools requirement

Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v72.2.0...v80.8.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-version: 80.8.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore!: 🔥 Remove deprecated support for Option in bridge commands (Pycord-Development#2731)

* 🔥 Remove deprecated support for Option in bridge commands

* 📝 CHANGELOG.md

* ♻️ Better logic

---------

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send (Pycord-Development#2761)

* 🐛 Handle `thread_name` in `handle_message_parameters` to allow sending to thread with multipart

* 📝 CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

---------

Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: plun1331 <plun1331@gmail.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* fix: add BanEntry to __all__ exports in guild.py (Pycord-Development#2798)

* fix: add BanEntry to __all__ exports in guild.py

* Hold on

Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

---------

Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* fix: correct generic return type in component utils (Pycord-Development#2796)

* Update CHANGELOG.md

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* sync with pycord

* fix: update Item type hints to Item[View] in view.py

* fix: update Item type hints to use TypeVar[V] in view.py

---------

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* chore(deps): update setuptools-scm requirement from <=8.2.1,>=6.2 to >=6.2,<=8.3.1 (Pycord-Development#2785)

chore(deps): update setuptools-scm requirement

Updates the requirements on [setuptools-scm](https://github.com/pypa/setuptools-scm) to permit the latest version.
- [Release notes](https://github.com/pypa/setuptools-scm/releases)
- [Changelog](https://github.com/pypa/setuptools-scm/blob/main/CHANGELOG.md)
- [Commits](pypa/setuptools-scm@v8.1.0...v8.3.1)

---
updated-dependencies:
- dependency-name: setuptools-scm
  dependency-version: 8.3.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): update pylint requirement from ~=3.3.6 to ~=3.3.7 (Pycord-Development#2784)

Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.3.6...v3.3.7)

---
updated-dependencies:
- dependency-name: pylint
  dependency-version: 3.3.7
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2792)

updates:
- [github.com/asottile/pyupgrade: v3.19.1 → v3.20.0](asottile/pyupgrade@v3.19.1...v3.20.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* docs: 📝 Fix malformed CHANGELOG.md hyperlinks (Pycord-Development#2804)

:memo: Fix CHANGELOG.md formatting

* fix: :bug: Fix `ValueError` when using `Flag` (Pycord-Development#2759)

* 🐛 Fix `dataclasses.field` can't be reused

* 📝 CHANGELOG.md

* Update CHANGELOG.md

Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* ♻️ Move `_missing_field_factory` to flags.py and remove incorrect comment

---------

Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

* ci(deps): bump crowdin/github-action from 2.7.0 to 2.7.1 in the patch-version-bumps group (Pycord-Development#2805)

ci(deps): bump crowdin/github-action in the patch-version-bumps group

Bumps the patch-version-bumps group with 1 update: [crowdin/github-action](https://github.com/crowdin/github-action).


Updates `crowdin/github-action` from 2.7.0 to 2.7.1
- [Release notes](https://github.com/crowdin/github-action/releases)
- [Commits](crowdin/github-action@v2.7.0...v2.7.1)

---
updated-dependencies:
- dependency-name: crowdin/github-action
  dependency-version: 2.7.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch-version-bumps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: resolve regex library warnings (Pycord-Development#2807)

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

* fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (Pycord-Development#2774)

* handle emoji_lib

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update CHANGELOG.md

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* usage of dismoji

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* Update _.txt

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* removal of dismoji

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* Update _.txt

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* NEED HELP 

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update partial_emoji.py

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Add files via upload

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update partial_emoji.py

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* Update discord/partial_emoji.py

Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Lumouille <144063653+Lumabots@users
95B4
.noreply.github.com>

* feature(partial_emoji): support :name: and name

* fix(partial_emoji): remove unnecessary data variable after processing emojis

* Update partial_emoji.py

Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* reduce emoji.json weight

* Update emojis.json

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* refactor: replace Path with importlib.resources for loading emojis.json

* Update emojis.json

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

---------

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>
Co-authored-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: Lala Sabathil <lala@pycord.dev>

* Revert "fix: support emoji aliases like `😄` in PartialEmoji.from_str" (Pycord-Development#2814)

Revert "fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (#…"

This reverts commit 735673b.

* Apply suggestions from code review

Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/utils.py

Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/utils.py

Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/ext/commands/flags.py

Signed-off-by: Paillat <jeremiecotti@ik.me>

* 🚨 Fix linter warnings

---------

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hema2 <49586027+Hema2-official@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Paillat-dev Paillat-dev Paillat-dev approved these changes

Assignees

@Hema2-official Hema2-official

Labels
bug Something isn't working priority: low Low Priority
Projects
Pycord Releases
Status: Done
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.

"list index out of range" error when connecting to voice channel voice_client receiving voice errors / not working ?
4 participants
@Hema2-official @Paillat-dev @JustaSqu1d @Lulalaby
0