bootstrap: fix overriden setuptools PEP 517 hooks #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the output can be an iterator? Using |
|
Nope, the PEP requires a "list of strings" and that's what setuptools already returns. |
config_settings is not supposed to have an underscore as per PEP 517. This changes the argument name to adhere to the PEP. Currently, this breaks pyproject-rpm-macros (Python build frontend used by Fedora Linux) which tries to pass a kwarg named `config_settings` and blows up. (We are considering changing pyproject-rpm-macros to pass it as a positional argument like pyproject-hooks/pip does, but this fix is still valid.) Additionally, the overriden get_requires_for_* hooks still should include the values from setuptools. Older setuptools versions include "wheel" here, for example.
messense
approved these changes
May 20, 2025
jollaitbot
pushed a commit
to sailfishos-mirror/pyproject-rpm-macros
that referenced
this pull request
Jun 21, 2025
PEP 517 says that the argument should be named config_settings but pip/pyproject-hooks and other build frontends just pass it as a positional argument, so some build backends name this argument other things. Even though those build backends are wrong, it still makes sense to align pyproject-rpm-macros with what the other frontends do. Ref: PyO3/maturin#2612 Ref: Rogdham/pyzstd#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config_settings is not supposed to have an underscore as per PEP 517. This changes the argument name to adhere to the PEP. Currently, this breaks pyproject-rpm-macros (Python build frontend used by Fedora Linux) which tries to pass a kwarg named
config_settingsand blows up. (We are considering changing pyproject-rpm-macros to pass it as a positional argument like pyproject-hooks/pip does, but this fix is still valid.)Additionally, the overriden get_requires_for_* hooks still should include the values from setuptools. Older setuptools versions include "wheel" here, for example.