8000 Fix platform tag on Solaris/Illumos by kulikjak · Pull Request #2483 · PyO3/maturin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix platform tag on Solaris/Illumos #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Fix platform tag on Solaris/Illumos #2483

merged 1 commit into from
Feb 23, 2025

Conversation

kulikjak
Copy link
Contributor

This fixes platform tag on Solaris/Illumos.

The problem is that os here can never be sunos, but rather solaris/illumos.

The following:

-                if os.starts_with("sunos") {
+                if os.starts_with("illumos") || os.starts_with("solaris") {

works as well, but checking the enum values seems nicer (and it's definitely faster). Using get_python_os would likely work as well, but I didn't go that way for the same reason.

@messense messense merged commit 862d8fb into PyO3:main Feb 23, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulikjak @messense
0