8000 New: admin-only checkbox for auto-report by AntoniaBK · Pull Request #914 · Lookyloo/lookyloo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New: admin-only checkbox for auto-report #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 16, 2024
Merged

Conversation

AntoniaBK
Copy link
Contributor
@AntoniaBK AntoniaBK commented May 8, 2024

Pull requests should be opened against the main branch. For more information on contributing to Lookyloo documentation, see the Contributor Guidelines.

Type of change

Description:

Select the type of change(s) made in this pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change or fix to documentation)

Fixes #issue-number

Proposed changes

  • admin-only auto-report checkbox at capture configuration: when it is checked a form is displayed where email, comment and recipient-email can be entered
  • moving all scripts of capture.html to capture.js
  • rewriting jQuery scripts of capture.js in vanilla JavaScript

@AntoniaBK AntoniaBK marked this pull request as ready for review May 14, 2024 12:26
@Rafiot
Copy link
Member
Rafiot commented May 14, 2024

Looks good!

While you're at it, can you use Template literals instead of string concatenations? I find it more readable.

@Rafiot Rafiot merged commit 3b6925c into Lookyloo:main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0