adding 3rd party report to mail #908
Conversation
|
Maybe it's not a good idea to reuse the modules function in init.py to filter the response from the 3rd party modules? |
I too would rather put all the filtering in an extra function that can be called when sending the mail and when displaying the 3rd-party lookups on the website. |
|
I think the concept of checking if the response is empty doesn't work.Urlscan triggers a scan (which wasn't the case at my lookyloo instance because it wasn't enabled) |
There was a problem hiding this comment.
Yeah, as you discussed, you should not reuse the method in __init__.py to do the post processing and put it in the mail. It makes more sense to create a new method in the Lookyloo class.
You might have to check one after the other all the keys in the response dict to make sure there is a response from any of the module.
8bbf2bf to
c5c1a8a
Compare
Pull requests should be opened against the
mainbranch. For more information on contributing to Lookyloo documentation, see the Contributor Guidelines.Type of change
Description:
Adding a 3rd party module section to the email template.
We want to display if an URL is malicious or not according to the 3rd party modules to provide more information.
Select the type of change(s) made in this pull request:
Fixes #issue-number
Proposed changes