Proxy with VT module #897
Merged
Proxy with VT module #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "trustenv" config parameter for the VT module
Modified the vt.Client instantiation to optionally read a value for trustenv from the modules config section.
Rafiot
reviewed
Mar 14, 2024
| @@ -33,7 +33,7 @@ def module_init(self) -> bool: | |||
| self.logger.info('Not enabled') | |||
| return False | |||
|
|
|||
| self.client = vt.Client(self.config['apikey']) | |||
| self.client = vt.Client(self.config['apikey'], trustenv=bool(self.config['trustenv'], False)) | |||
There was a problem hiding this comment.
just FYI, the correct name of the parameter is trust_env, not trustenv. And bool(self.config['trustenv'], False) isn't a valid syntax. I guess you wanted to do something like self.config.get('trustenv', False)
There was a problem hiding this comment.
😱 so sorry! Thanks for the catch!
There was a problem hiding this comment.
No worries, it is fixed in the repo ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be appli
2EA6
ed while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Modified the vt.py module so that the vt.Client reads the
trustenvparameter from the module's config section if present.Current functionality sees the
trustenvparameter to vt.Client default toFalse. Unless the new config parameter is used,Falseremains the default.Select the type of change(s) made in this pull request:
Fixes #896
Proposed changes
trustenvparameter to the vt module's configtrustenvparameter from the module config file (if present)