feat(Import): Add support to merge several pages into a stage during import #5958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
how about:
- using comma as separator - I know it is a valid character for a pagename, but is it ever used from a practical perspective?
- allowing a JSON array to be passed in, i.e., make
pageNameStringbe a pagenamestringor string representation of a JSON array?
I'm just not a huge fan of introducing a new separator ({{!}}{{!}}); otherwise lgtm
input pattern is up for discussion of course |
|
I also dislike the separator - i don't really mind which of the other options listed we use, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes groups are spread across several pages due to runtime/memory limitations and making them easier to edit.
If those groups consist of brackets instead of groupTables this currently means we can not import them in prize pool due to the prize pool assuming the brackets belong to different stages.
To be able to fetch data from different pages for the same stage this PR adds the option to input several pagenames into the tournamentX parameters with
||(in wikicode{{!}}{{!}}) as delimiter (this delimiter can not be used in pagenames, and hence is imo preferabel to others that could be used in pagenames).example code (on sc2):
{{SoloPrizePool|qualifies1=Esports_World_Cup/2025|qualifies1name=Esports World Cup 2025|dev=hjp |tournament1=2025_DreamHack/Dallas/Bracket_A{{!}}{{!}}2025_DreamHack/Dallas/Bracket_B{{!}}{{!}}2025_DreamHack/Dallas/Bracket_C{{!}}{{!}}2025_DreamHack/Dallas/Bracket_D |tournament2=2025_DreamHack/Dallas }}How did you test this change?
dev