8000 fix: some components show score with 2 decimal places by hjpalpha · Pull Request #5957 · Liquipedia/Lua-Modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: some components show score with 2 decimal places #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: some components show score with 2 decimal places #5957

wants to merge 3 commits into from

Conversation

hjpalpha
Copy link
Collaborator

Summary

image
the score display with 2 decimal places only happens if advantage/penalty is set

this PR accounts for these edge cases

How did you test this change?

dev

@hjpalpha hjpalpha requested a review from Rathoz May 23, 2025 17:48
@hjpalpha hjpalpha force-pushed the fix-sc2-score-display-edge-cases branch from ef80350 to ca5af28 Compare May 23, 2025 19:31
@Rathoz
Copy link
Collaborator
Rathoz commented May 28, 2025 •
edited
Loading

Is this the correct way of solving it? Isn't using OpponentDisplay.InlineScore better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rathoz Rathoz Awaiting requested review from Rathoz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
c: opponent g: starcraft Starcraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpalpha @Rathoz
0