feat(match2): add support for gameScoresIfBo1 config to match page #5936
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
May 16, 2025
de396f0 to
066b4a8
Compare
Rathoz
reviewed
May 16, 2025
Rathoz
reviewed
May 16, 2025
Rathoz
reviewed
May 20, 2025
a7122e8 to
e6fef1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of match page header always displays match score. This PR adds support for
gameScoresIfBo1(used by VAL wiki) so that the header displays scores from game 1 if the match is Bo1.How did you test this change?
dev