8000 fix: WantToHelpList not processing wiki inputted limit by SlothyMan · Pull Request #5926 · Liquipedia/Lua-Modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: WantToHelpList not processing wiki inputted limit #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SlothyMan
Copy link
Collaborator

Summary

reported on discord. Want to help/all showing only 3 pages despite setting up limit to 5000.
https://discord.com/channels/93055209017729024/268719633366777856/1371501821562191872

Not sure if best fix, but I believe someone else can fix it if this is not enough :D

How did you test this change?

dev
image
image

Copy link
Collaborator
@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would break lots of main pages

rather use
args = Arguments.getArgs(args)

(also adjust annotation)

Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
@hjpalpha hjpalpha changed the title fix WantToHelpList.lua fix: WantToHelpList not processing wiki inputted limit May 13, 2025
@hjpalpha hjpalpha requested a review from Rathoz May 13, 2025 06:21
@Rathoz
Copy link
Collaborator
Rathoz commented May 14, 2025

Can we quickly rewrite it as a widget instead? It basically is one already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0