8000 fix(match2): display title for match page not being applied in certain conditions by ElectricalBoy · Pull Request #5919 · Liquipedia/Lua-Modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(match2): display title for match page not being applied in certain conditions #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElectricalBoy
Copy link
Collaborator
@ElectricalBoy ElectricalBoy commented 8000 May 9, 2025

Summary

Currently, in certain scenarios (e.g., tournament does not have tickername) the match page does not apply display title after it is generated.
This PR adjusts display title generation logic to cover such cases.

How did you test this change?

dev

@ElectricalBoy ElectricalBoy requested a review from Rathoz May 9, 2025 08:17
@ElectricalBoy ElectricalBoy changed the title fix(match2): display title for match page not being generated in certain conditions fix(match2): display title for match page not being applied in certain conditions May 9, 2025
Copy link
Collaborator
@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0