8000 feat: create VOR table for cs wiki by iMarbot · Pull Request #5737 · Liquipedia/Lua-Modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: create VOR table for cs wiki #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: create VOR table for cs wiki #5737

wants to merge 7 commits into from

Conversation

iMarbot
Copy link
Collaborator
@iMarbot iMarbot commented Mar 30, 2025 •
edited
Loading

Summary

Preface: I'm not 100% sure if this should be on the git repo - happy to go either way on it.

Implements a new "Valve Operational Requirements" table for the CS wiki. Will be used on a large chunk of tournament pages going forward.

The reason for LPDB storage is to allow querying some of the VRS data fields for use in teamcards' qualifier section.

image
(https://liquipedia.net/counterstrike/User:IMarbot/TOR)

How did you test this change?

Tested directly on new module name with that user page.

Merge Prerequisites

@iMarbot iMarbot added the g: counter-strike Counter-Strike label Mar 30, 2025
@iMarbot iMarbot self-assigned this Mar 30, 2025
hjpalpha
hjpalpha reviewed Mar 31, 2025
View reviewed changes
Copy link
Collaborator
@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some early return adjusts to reduce indents a tiny bit in those fucntions

@iMarbot @hjpalpha
Apply suggestions from code review (early returns)
2ad81e6 
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
hjpalpha approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator
@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on mobile

ElectricalBoy
ElectricalBoy reviewed Apr 1, 2025
View reviewed changes
@iMarbot iMarbot requested review from ElectricalBoy and Rathoz April 6, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElectricalBoy ElectricalBoy ElectricalBoy approved these changes

@hjpalpha hjpalpha hjpalpha approved these changes

@ZaykorDE ZaykorDE Awaiting requested review from ZaykorDE

@Rathoz Rathoz Awaiting requested review from Rathoz

Assignees

@iMarbot iMarbot

Labels
g: counter-strike Counter-Strike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMarbot @ElectricalBoy @hjpalpha
0