Clang 18 #202
Clang 18 #202
Conversation
Merge branch '149-migrate-clang-version' of https://github.com/Lind-Project/lind-wasm into 149-migrate-clang-version
|
@yzhang71 there are several merge conflicts here |
| $$CC $$CFLAGS $$WARNINGS $$EXTRA_FLAGS \ | ||
| $$INCLUDE_PATHS $$SYS_INCLUDE $$DEFINES $$EXTRA_DEFINES \ | ||
| -o $$GLIBC_BASE/build/lind_syscall.o \ |
There was a problem hiding this comment.
The merge from main might have removed the lind_syscall compile here
There was a problem hiding this comment.
Yes, but I'm not sure if it's necessary, since lind_syscall.o is pre-shipped in the lind_syscall folder, right?
There was a problem hiding this comment.
This seems like a problem. I believe we changed it to compile every time and not pre-ship since that was causing constant issues.
Good catch! Conflicts are resolved. |
|
Test Report |
|
Test Report |
|
the |
.devcontainer/Dockerfile
Outdated
| sudo | ||
| RUN apt-get update && \ | ||
| apt-get install -y build-essential git wget gcc-i686-linux-gnu g++-i686-linux-gnu \ | ||
| bison gawk vim libxml2 python3 curl gcc g++ binaryen unzip zip golang bash |
There was a problem hiding this comment.
It looks like some items were removed from this that we need
| groupmod --new-name ${USERNAME} ubuntu | ||
| RUN echo "lind ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers | ||
| RUN groupadd --gid 1000 $USERNAME && \ | ||
| useradd --uid 1000 --gid $USERNAME --create-home --shell /bin/bash $USERNAME && \ |
There was a problem hiding this comment.
Nice cleanup here, like the flexibility it introduces for other users if necessary
|
Commit 97c9c8c: Build Success |
|
Commit 85e25c3: Build Success |
|
Test Report |
|
@yzhang71 if you merge main into here and fix the conflicts this should build with CI now |
|
Commit 6e18b65: Build Success |
|
Test Report |
I'm wondering if this is related to Ansal's above lind_syscall.o comment |
Just looked into the reason of the test report failure and I believe it is related to @m-hemmings could you take a look and see if you can fix the issue, so that test could run normally for all PRs? |
|
Commit c18e83d: Build Success |
|
The gen_sysroot.sh was not working because it failed to find the lind_syscall.o while bundling. It can be fixed in two ways. I made the change where we compile lind_syscall during bazel build. If that is to be changed to prepackage lind_syscall.o(like crt1.o), there should be a corresponding change in gen_sysroot.sh mentioning the path. |
Thank you @ansalma6! Can you (or @m-hemmings make sure this stuff is documented somewhere in the build docs) @qianxichen233 does this clarify your concerns? |
|
Test Report |
|
The test report looks much better now. @yzhang71 , could you also take a look at the test report here and compare the test results with those from the main branch? Just want to make sure no additional tests are failing in this PR. |
No problem. I will work on that |
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
lind_project/tests/test_cases/test_a.clind_project/tests/test_cases/test_b.cChecklist: