-
Notifications
You must be signed in to change notification settings - Fork 4
Y333/update after Donjon review #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
You can look into enabling the fees tests on the Exchange tests side too
edec73f
to
834d0f6
Compare
Activated in https://github.com/LedgerHQ/app-exchange/tree/y333/enable_fees_tests_for_ton but fees are not checked when performing a TON swap (and they are not passed in the Tx), but only for Jetton swap.... |
Integrate Donjon comments after review of #17