8000 Y333/update after Donjon review by yogh333 · Pull Request #24 · LedgerHQ/app-ton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Y333/update after Donjon review #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 25, 2025
Merged

Conversation

yogh333
Copy link
@yogh333 yogh333 commented May 22, 2025

Integrate Donjon comments after review of #17

@yogh333 yogh333 changed the title Y333/update after donjon review Y333/update after Donjon review May 22, 2025
@yogh333 yogh333 requested a review from bboilot-ledger May 22, 2025 12:37
fbeutin-ledger
fbeutin-ledger previously approved these changes May 23, 2025
Copy link
@fbeutin-ledger fbeutin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
You can look into enabling the fees tests on the Exchange tests side too

@yogh333 yogh333 force-pushed the y333/update_after_donjon_review branch from edec73f to 834d0f6 Compare May 23, 2025 13:51
@yogh333
Copy link
Author
yogh333 commented May 25, 2025

Looks good! You can look into enabling the fees tests on the Exchange tests side too

Activated in https://github.com/LedgerHQ/app-exchange/tree/y333/enable_fees_tests_for_ton but fees are not checked when performing a TON swap (and they are not passed in the Tx), but only for Jetton swap....

@yogh333 yogh333 merged commit a7ed07e into develop May 25, 2025
185 checks passed
@yogh333 yogh333 deleted the y333/update_after_donjon_review branch May 25, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0