8000 Fixing tests, added gitattributes by alexz707 · Pull Request #6 · LM-Commons/LmcUser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing tests, added gitattributes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 1, 2020
Merged

Fixing tests, added gitattributes #6

merged 5 commits into from
Dec 1, 2020

Conversation

alexz707
Copy link

Fixing Travis Tests,
added Gitattributes to not export all config files and tests

@alexz707 alexz707 requested a review from matwright November 23, 2020 12:11
@alexz707
Copy link
Author
alexz707 commented Nov 23, 2020 •
edited
Loading

As already mention in the issue #3 the unit tests were not executed.
This pull requests fixes the unit tests and I also added a git attributes file so "unimportant" configs like travis won't be exported.
@matwright: please have a look ;-)

@alexz707
Copy link
Author

Added a fix for the badges in the readme file, they were redirecting only to the badge-images.
now they redirect to the project

@alexz707 alexz707 requested a review from visto9259 December 1, 2020 11:40
@alexz707
Copy link
Author
alexz707 commented Dec 1, 2020

Can one of you guys please review and tell me if that's ok? @visto9259 @matwright
Test aren't working atm and I have many things to commit after that ;-)
Thanks ;)

matwright
matwright approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor
@matwright matwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @alexz707

@matwright matwright merged commit 1415342 into LM-Commons:master Dec 1, 2020
@alexz707 alexz707 deleted the Travis-Fix branch January 5, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign 62CC in to comment
Reviewers

@matwright matwright matwright approved these changes

@visto9259 visto9259 Awaiting requested review from visto9259

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexz707 @matwright
0