8000 Developer docs by balos1 · Pull Request #361 · LLNL/sundials · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Developer docs #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 12, 2023
Merged

Developer docs #361

merged 11 commits into from
Nov 12, 2023

Conversation

balos1
Copy link
Member
@balos1 balos1 commented Oct 31, 2023 •
edited
Loading

Also adds instructions for updating answers in the developer docs.

RTD preview: https://sundials.readthedocs.io/en/feature-udpating-answers-instructions/

@balos1 balos1 added the docs label Oct 31, 2023
@balos1 balos1 changed the title Feature/udpating answers instructions Developer docs Oct 31, 2023
drreynolds
drreynolds previously approved these changes Nov 2, 2023
View reviewed changes
@balos1 balos1 added this to the SUNDIALS Next milestone Nov 6, 2023
@balos1 balos1 requested a review from drreynolds November 9, 2023 05:32
gardner48
gardner48 requested changes Nov 9, 2023
View reviewed changes
@drreynolds
Copy link
Collaborator

Do the docs in each PR get built automatically? If so, could we add the ReadTheDocs URL for this PR as a comment here?

@balos1
Copy link
Member Author
balos1 commented Nov 9, 2023

Yes, for this branch I told RTD to build the docs automatically. Here is the link https://sundials.readthedocs.io/en/feature-udpating-answers-instructions/

@balos1
Copy link
Member Author
balos1 commented Nov 12, 2023

GitLab CI is reporting as failed since Corona is (or was) down. I will rerun the jobs. It would be nice to merge this PR before the removal of deprecated code PR @gardner48.

gardner48
gardner48 previously approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member
@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question about the submodule remote but otherwise this looks good.

We'll need to make some updates for displaying graphviz figures on the readthedocs page (or it seems that way on my phone) but that's a separate issue.

@balos1 balos1 requested a review from gardner48 November 12, 2023 17:40
@gardner48 gardner48 merged commit 1b913be into develop Nov 12, 2023
@gardner48 gardner48 deleted the feature/udpating-answers-instructions branch November 12, 2023 19:29
gardner48 added a commit that referenced this pull request Dec 18, 2023
@balos1 @gardner48
Developer docs (#361)
bbf3270 
Add developer docs to RTD superbuild
Add instructions for updating answers in the developer docs.

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
balos1 added a commit that referenced this pull request Dec 18, 2023
@balos1 @gardner48
Developer docs (#361)
b8dd535 
Add developer docs to RTD superbuild
Add instructions for updating answers in the developer docs.

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 approved these changes

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

@drreynolds drreynolds Awaiting requested review from drreynolds drreynolds is a code owner

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
SUNDIALS 7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@balos1 @drreynolds @gardner48
0