Fix non-snaking slide transforms not resetting before entry animation #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating, it seems that the cause of chevrons not reappearing when snaking is off comes from the lazy progress updates used in this method. The problem occurs specifically on completion of the slide. The slide would trigger the exit animation transform BEFORE the progress is updated. The transforms will then play out, and may only complete during the next use, causing a few chevrons to be missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chevrons could be either visible or invisible depending on whether the previous slide has been completed or not. The transforms used during the non-snaking transforms resets the chevrons back to full alpha at the end, instead of at the front. The original transforms were due to me trying to rush things, and copied the same thing from the snaking transforms, without realizing that it was not helping anything.