Adjust judgements to internally use GREAT/GOOD/OK #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change in global hitresult values introduced in ppy/osu#12294, GREAT and GOOD were worth 95% and ~63% relative to PERFECT, from the previous values of ~86% and 57% respectively. For obvious reasons this makes the game way too lenient, where plenty of leniencies are already in place.
Now, all hit results now use GREAT/GOOD/OK as valid results internally (100%, 66% and 33% respectively). The user facing side of these results (DrawableJudgements, endgame scorecard) will have the results names altered to match PERFECT/GREAT/GOOD.
I personally agree that the method I used to change the display names of hit results is hacky as fuck, but "Perfect" is just a better fit for a 100% hit than "Great", and I want to keep that, without having awkward result values.