Implement connected HitObjectLine for twin notes #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still quite buggy, but works
The extra layer of lifetime management causes problems with no benefits.
Trimmed large amount of blank space, and pngcrushed textures. Also pngcrushed the other textures while I'm at it.
This would be used in the editor, where it is expected that Lines get updated as hitobjects are added/removed or their properties modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, individual laned
HitObjectsmaintained their own HitObjectLine. Their line remained static and didn't consider the presence of a twin.This PR decouples the
HitObjectLinefrom the HitObject drawables, and delegate the task of rendering the lines to aHitObjectLineRendererwithinLanedPlayfield. The renderer functions similarly to osu!standard'sFollowPointRenderer.The renderer has full knowledge of all HitObjects present within the session, and groups HitObjects based on their StartTime. Each group is then assigned a
HitObjectLineEntry(derived from LifetimeEntry), which determine the type of line that it is based on the amount of HitObjects in that group, and their assigned lanes. TheHitObjectLineEntryis then used by the renderer to Add/Remove the appropriate Line Drawable to/from the hierarchy. The lines are pooled ahead-of-time based on their type.Example of a connected line for a set of twins (White dots represent the lanes of the HitObjects):
There are currently five line types, which are as follows