[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LEMS-2662): handle angle aria label updates #1940

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(LEMS-2662): handle angle aria label updates #1940

wants to merge 5 commits into from
+248 −28

Conversation

anakaren-rojas
Copy link
Contributor
@anakaren-rojas anakaren-rojas commented Dec 2, 2024 •
edited
Loading

Summary:

  • Adds SR functionality for angle sides and vertex
  • Pulls getClockwiseCoords and getWholeAngleMeasure into independent functions from angle indicator
  • Adds variations of 6 variations of angle strings - initial side copy (x2), updated side copy (x2), initial vertex copy, updated vertex copy

Issue: LEMS-2662

Test plan:

@anakaren-rojas anakaren-rojas self-assigned this Dec 2, 2024
@anakaren-rojas anakaren-rojas changed the title handle angle aria label updates feat(LEMS-2662): handle angle aria label updates Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 3, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (59b0d2f) and published it to npm. You
can install it using the tag PR1940.

Example:

yarn add @khanacademy/perseus@PR1940

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1940

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 3, 2024

Size Change: +850 B (+0.07%)

Total Size: 1.29 MB

Filename Size Change
packages/math-input/dist/es/index.js 77.9 kB +1 B (0%)
packages/perseus/dist/es/index.js 423 kB +569 B (+0.13%)
packages/perseus/dist/es/strings.js 3.98 kB +280 B (+7.57%) 🔍
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 697 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anakaren-rojas anakaren-rojas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anakaren-rojas