Fix for Input Numbers in Explanation Widgets #1900
Open
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (bd376eb) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1900If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1900 |
mark-fitzgerald
approved these changes
Nov 21, 2024
Myranae
approved these changes
Nov 21, 2024
|
Size Change: +108 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
|
Could you attach a representative piece of data to this PR for posterity? I also don't really understand the issue based on the description. Even if you come back after the p0 event is over, I'd love to see this PR filled out a bit more for historical purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR implements a quick bug fix for a p0 issue related to explanation widget, as it does not follow the typical PerseusRenderer format. I've also added some extra safety checks.
Test plan: