8000 Fix the "id" of the comments in the list by algorythm · Pull Request #6 · JonPSmith/EfCoreInAction · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the "id" of the comments in the list #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: Chapter05
Choose a base branch
from
Open

Fix the "id" of the comments in the list #6

wants to merge 1 commit into from

Conversation

algorythm
Copy link

You use #A, #B, #C, #D and #E in the code, but the list in the bottom was incorrect.

@algorythm
Fix the "id" of the comments in the list
392f17e 
You use #A, #B, #C, #D and #E in the code, but the list in the bottom was incorrect.
@JonPSmith
Copy link
Owner

Hi @algorythm,

Thanks for that. I don't think I can submit this merge as it would break the "branch-per-chapter" setup. It looks like this is used first in chapter 2, so I will hand-edit that branch. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algorythm @JonPSmith
0