Welcome improvements #9
Conversation
|
Thank you! Why revert the changes though? |
another attempt to make github diff .inc files
Hi, sorry, was attempting to make diff work on the .inc files. I have added them back |
|
I'm a little new to github so i'm trying to figure things out. |
|
I found that the Rainmeter.data file is storing whether gamemode is on or not. |
|
I saw that toggling Hardware acceleration reloads Rainmeter completely and toggling Game Mode reloads the Rainmeter settings windows (because the script is setting the option through that then closing it) I thought it might b 8000 e better to toggle these options temporarily using variables then having an apply button appear to apply them before continuing. But this would change how the page works and is a bit more work, so I decided to do it this way for now. Let me know what you think, I can do it first and you can try it see if you like it. |
|
I found you can see my changes more easily here: It shows on the left which commit added the line. |
|
Thanks for the PR. I'll review the changes later down this week <3 |
This behavior is normal and should be preserved. The files are saved with UTF-16 encoding, which Github recognizes as binary files. |
Just so we are clear, are you saying the binary interpretation should be preserved or just the UTF-16 encoding? |
I am pretty sure you can't "remove" the binary interpretation with non-UTF-8 encoding... |
Please check my latest commits. I just did ;) |
Hi.
I was bothered by the Welcome/Installation options not being togglable, so I decided to try to fix it myself.
I hope this works.
Note:
I noticed that Performance mode sets FadeDuration and blur. I'm not 100% what the default values should be, but I think I found the right ones?
[!FadeDuration 100 "#JaxCore\Main"][!WriteKeyValue Variables Set.Blur Blur "#@#Vars.inc"]