8000 feat: add ability to use cedarling authz before and after authentication by duttarnab · Pull Request #11203 · JanssenProject/jans · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add ability to use cedarling authz before and after authentication #11203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2025
Merged

feat: add ability to use cedarling authz before and after authentication #11203

merged 5 commits into from
Apr 12, 2025

Conversation

duttarnab
Copy link
Contributor
@duttarnab duttarnab commented Apr 9, 2025 •
edited
Loading

Prepare

Description

Target issue

closes #11202

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@duttarnab
feat: add ability to use cedarling authz before and after authentication
fb74d05 
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Apr 9, 2025
@moabu moabu requested a review from Copilot April 9, 2025 15:09
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • demos/jans-tarp/src/options/cedarlingBootstrap.json: Language not supported
  • demos/jans-tarp/tsconfig.json: Language not supported

@duttarnab @Copilot
Update demos/jans-tarp/src/options/addCedarlingConfig.tsx
dacceda 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@duttarnab duttarnab requested review from rizarsyi and moabu April 10, 2025 16:58
rizarsyi
rizarsyi reviewed Apr 11, 2025
View reviewed changes
Copy link
@rizarsyi rizarsyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean the console log

demos/jans-tarp/src/options/addCedarlingConfig.tsx Outdated
Comment on lines 74 to 76
console.log("JSON copied to clipboard!" + jsonString);
} catch (error) {
console.error("Copy failed:", error);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using toast or alert is more user friendly instead of console log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@duttarnab
feat: adding toast for copy to clipboard
d22b05c 
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@duttarnab duttarnab requested a review from rizarsyi April 11, 2025 17:57
@moabu moabu merged commit 6652a4a into main Apr 12, 2025
2 checks passed
@moabu moabu deleted the jans-tarp-issue-11202 branch April 12, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rizarsyi rizarsyi rizarsyi approved these changes

@nynymike nynymike nynymike approved these changes

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-tarp): add ability to use cedarling authz before and after authentication
5 participants
@duttarnab @rizarsyi @nynymike @moabu @mo-auto
0