8000 fix(jans-cedarling): fix usage outdated field resource_type by olehbozhok · Pull Request #11266 · JanssenProject/jans · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(jans-cedarling): fix usage outdated field resource_type #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

fix(jans-cedarling): fix usage outdated field resource_type #11266

merged 4 commits into from
Apr 23, 2025

Conversation

olehbozhok
Copy link
Contributor

Prepare

Description

Updated examples and documentation

Target issue

link

closes #11265

Implementation Details

Updated:

  • python example and documentation file (regenerated)
  • uniffi ios and android examples

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@olehbozhok
fix(jans-cedarling): fix usage resource_type in python bindings
6d0aebc 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok
fix(jans-cedarling): updated usage outdated field names to avoid confuse
9d5c424 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok added the comp-jans-cedarling Touching folder /jans-cedarling label Apr 22, 2025
@olehbozhok olehbozhok self-assigned this Apr 22, 2025
@mo-auto
Copy link
Member
mo-auto commented Apr 22, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@olehbozhok olehbozhok changed the title Jans cedaling issue 11265 fix(jans-cedarling): fix usage outdated field resource_type Apr 22, 2025
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality labels Apr 22, 2025
rmarinn
rmarinn previously approved these changes Apr 23, 2025
View reviewed changes
@olehbozhok
fix(jans-cedarling): fix uniffi binding build
ba87691 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok requested a review from rmarinn April 23, 2025 16:20
@olehbozhok olehbozhok enabled auto-merge (squash) April 23, 2025 16:20
@olehbozhok olehbozhok merged commit 98dfa1b into main Apr 23, 2025
2 checks passed
@olehbozhok olehbozhok deleted the jans-cedaling-issue-11265 branch April 23, 2025 16:26
@duttarnab duttarnab requested review from nynymike and removed request for nynymike April 25, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SafinWasi SafinWasi SafinWasi approved these changes

@duttarnab duttarnab duttarnab approved these changes

@rmarinn rmarinn Awaiting requested review from rmarinn

Assignees

@olehbozhok olehbozhok

Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-cedarling): fix usage outdated field resource_type
5 participants
@olehbozhok @mo-auto @SafinWasi @duttarnab @rmarinn
0