8000 fix: admin-ui plugin should send appropriate message on expiry/ for inactive license. #10178 by duttarnab · Pull Request #10189 · JanssenProject/jans · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: admin-ui plugin should send appropriate message on expiry/ for inactive license. #10178 #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: admin-ui plugin should send appropriate message on expiry/ for inactive license. #10178 #10189

merged 2 commits into from
Nov 19, 2024

Conversation

duttarnab
Copy link
Contributor

closes #10178

@duttarnab
fix: admin-ui plugin should send appropriate message on expiry/ for i…
de24d3c 
…nactive license. #10178

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@dryrunsecurity DryRunSecurity
Copy link
dryrunsecurity bot commented Nov 19, 2024 •
edited
Loading

DryRun Security Summary

The pull request primarily focuses on enhancing the license management functionality of the application, including the addition of a new property to the LicenseResponse class, the introduction of new error responses related to license management, and various improvements to the LicenseDetailsService class to handle API responses, error scenarios, and the secure storage of license-related data.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on enhancing the license management functionality of the application. The changes include the addition of a new property called "licenseExpired" in the LicenseResponse class, the introduction of new error responses related to license management, and various improvements to the LicenseDetailsService class.

From an application security perspective, these changes do not appear to introduce any significant security vulnerabilities. The new property and error responses are related to the handling of license-related information, which is a common requirement in software applications that use licensing mechanisms. The changes in the LicenseDetailsService class also focus on improving the handling of API responses, error scenarios, and the secure storage of license-related data.

While the changes are not directly related to security-critical functionality, it's important to ensure that the overall license management process is implemented securely. This includes securing the storage of sensitive license data, validating the integrity and authenticity of license-related information, and gracefully handling expired or invalid licenses to prevent unauthorized access or functionality.

Files Changed:

  1. jans-config-api/plugins/admin-ui-plugin/src/main/java/io/jans/ca/plugin/adminui/model/auth/LicenseResponse.java:

    • Added a new property called "licenseExpired" to the LicenseResponse class, which is a boolean flag indicating whether the license has expired or not.

  2. jans-config-api/plugins/docs/jans-admin-ui-plugin-swagger.yaml:

    • Updated the "LicenseResponse" schema to include the new "licenseExpired" property.

  3. jans-config-api/plugins/admin-ui-plugin/src/main/java/io/jans/ca/plugin/adminui/utils/ErrorResponse.java:

    • Added two new error responses: "LICENSE_IS_EXPIRED" and "LICENSE_DATA_MISSING", which are related to license management.

  4. jans-config-api/plugins/admin-ui-plugin/src/main/java/io/jans/ca/plugin/adminui/service/license/LicenseDetailsService.java:

    • Introduced a new method handleMissingFieldsInResponse() to check for missing fields in the license API response.
    • Improved error handling and logging for various license-related operations.
    • Added methods for saving the license configuration, generating access tokens, activating licenses, generating trial licenses, and retrieving license details.

Overall, the changes in this pull request appear to be focused on enhancing the license management functionality of the application, with a focus on improving error handling and ensuring the secure storage and handling of license-related data.

Code Analysis

We ran 9 analyzers against 4 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Authn/Authz Analyzer 1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-docs Touching folder /docs comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yuriyz yuriyz enabled auto-merge (squash) November 19, 2024 14:48
@yuriyz yuriyz merged commit 7347e04 into main Nov 19, 2024
10 of 11 checks passed
@yuriyz yuriyz deleted the jans-config-api-issue-10178 branch November 19, 2024 14:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yuriyzz yuriyzz yuriyzz approved these changes

@pujavs pujavs Awaiting requested review from pujavs pujavs is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-docs Touching folder /docs comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-config-api): admin-ui plugin should send appropriate message on expiry/ for inactive license.
4 participants
@duttarnab @yuriyz @yuriyzz @mo-auto
0