-
Notifications
You must be signed in to change notification settings - Fork 85
ProjectPasskeys: fix(jans-fido2): Major FIDO2 / Passkeys upgrade #9120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DryRun Security SummaryThe pull request covers various updates and improvements to the FIDO2 authentication implementation in the Janssen application, focusing on enhancing security, configurability, logging, and monitoring of the FIDO2 functionality. Expand for full summarySummary: The code changes in this pull request cover various updates and improvements to the FIDO2 (Fast Identity Online) authentication implementation in the Janssen (Jans) application. The changes focus on enhancing the security and configurability of the FIDO2 functionality, with a particular emphasis on the following areas:
Files Changed:
Overall, the changes in this pull request appear to be focused on improving the security and configurability of the FIDO2 implementation in the Janssen application. As an application security engineer, it is important to thoroughly review these changes and ensure that the FIDO2 implementation continues to adhere to best practices and industry standards for secure authentication. Code AnalysisWe ran
Riskiness🟢 Risk threshold not exceeded. |
|
|
|
* feat: add support for BS / BE flags in AuthData #8903 Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com> * feat: adding comments Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com> * feat: adding comments Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com> --------- Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com> Co-authored-by: Ackermann Yuriy <1636116+yackermann@users.noreply.github.com>
|
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
* Lock / Cedarling doc updates ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Michael Schwartz * fix(docs): proofreading Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> --------- Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Co-authored-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
* fix(jans-auth): fix AD user authentication Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> * fix(jans-auth): fix AD user authentication Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> --------- Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
…9133) * fix(config-api): asset mgt endpoint fixes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> --------- Signed-off-by: pujavs <pujas.works@gmail.com> Co-authored-by: Devrim <devrimyatar@gluu.org>
…hbase persistence (#9134) * fix(docker-jans-saml): kc-jans-spi throws error if using spanner/couchbase persistence Signed-off-by: iromli <isman.firmansyah@gmail.com> * fix: extract spanner/couchbase libs into KC providers directory Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: mzico <mohib@gluu.org> Co-authored-by: Dhaval D <343411+ossdhaval@users.noreply.github.com>
…jans into passkeys-project
(#9141) Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
…#8910) * docs: add network traffic notes * docs: add network traffic notes Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: add external communication Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: add note to avoid java args break Signed-off-by: Amro Misbah <amromisba7@gmail.com> * Revert "docs: add note to avoid java args break" This reverts commit 9f22446. * feat: add custom service Account, labels and annotations * docs: generate helm-docs * fix: resolve conflict Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: resolve conflicts Signed-off-by: Amro Misbah <amromisba7@gmail.com> * fix: add lock additional labels and annotations Signed-off-by: Amro Misbah <amromisba7@gmail.com> * fix: reference labels and annotations correctly Signed-off-by: Amro Misbah <amromisba7@gmail.com> * fix: consistent order * fix(nginx-ingress): pass one argument to toYaml function Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: generate helm-docs Signed-off-by: Amro Misbah <amromisba7@gmail.com> --------- Signed-off-by: Amro Misbah <amromisba7@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
* fix(config-api): asset mgt endpoint fixes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): asset upload Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): lock review comments Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock code review comments Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: 8000 pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> --------- Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
* feat(jans-casa): fix bioid flow launching Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> * docs(jans-casa): fix instructions Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> --------- Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
* fix(cloud-native): resolve opentelemetry error on keycloak startup Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: downgrade keycloak version to 25.0.6 Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
|
|
|
|
|
|
|
|
docs: add release process Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
* feat(jans-fido2): reflect authenticator name with passkeys Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * fix(jans-fido2): handle test cases for authenticator name Signed-off-by: imran-ishaq <imranishaq024@gmail.com> --------- Signed-off-by: imran-ishaq <imranishaq024@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
#9624) fix(jans-fido2): remove superGluu-related endpoints from FIDO2 Swagger and ConfigurationControllerTest Signed-off-by: imran-ishaq <imranishaq024@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
….0-M12 to 4.0.0-M16 in /jans-scim (#9010) chore(deps): bump org.apache.maven.plugins:maven-site-plugin Bumps [org.apache.maven.plugins:maven-site-plugin](https://github.com/apache/maven-site-plugin) from 4.0.0-M12 to 4.0.0-M16. - [Commits](apache/maven-site-plugin@maven-site-plugin-4.0.0-M12...maven-site-plugin-4.0.0-M16) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jose Gonzalez <bonustrack310@gmail.com>
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
…tion and assertion API calls #9248 (#9974) * feat(jans-fido2): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * refactor(docs): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * fix(jans-fido2): handle origin if http or https is missing #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> --------- Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
|
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Closed in favor of a rebase here #10078 |
This PR completely revamps jans-fido2, to enable support for passkeys, and bring the server up to spec.
So far changes: