Capability to access user shared data #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoina
commented
May 16, 2025
fileglancer_central/app.py
Outdated
| @@ -53,14 +54,14 @@ def cache_wiki_paths(confluence_url, confluence_token, force_refresh=False): | |||
|
|
|||
|
|
|||
|
|
|||
| def get_file_proxy_client(sharing_key: str, sharing_name: str) -> FileProxyClient | Response: | |||
| def _get_file_proxy_client(sharing_key: str, sharing_name: str) -> FileProxyClient | Response: | |||
There was a problem hiding this comment.
I prefer this convention - it gives me the illusion the method is used only in this file. Let me know if you want me to revert it
cgoina
commented
May 16, 2025
| return False | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
I left this in here - because I just did some additional testing but it can be removed
krokicki
approved these changes
May 16, 2025
| logger.debug("Release user context") | ||
| os.seteuid(self._uid) | ||
| os.setegid(self._gid) | ||
| self._user = None |
There was a problem hiding this comment.
we probably should - I will do that too
| if isinstance(client, Response): | ||
| return client | ||
| return await client.head_object(path) | ||
| with userctx: |
cgoina
commented
May 16, 2025
| logger.error(f"Failed to set the effective gid: {e}") | ||
| raise e | ||
|
|
||
| try: |
There was a problem hiding this comment.
@krokicki on my mac I ran into an exception when I tried to restore the groups - the number of groups my root has on mac is larger than the number allowed to set. So I added this check just to see if this happens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a UserContext that allows accesing shared data.