-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile on MacOS #98
Compile on MacOS #98
Conversation
Compile on MacOS fix JakobEngel#26 Also I have problem with code compile. Fixed by changing type of `connectivityMap` to: std::map<uint64_t,Eigen::Vector2i> connectivityMap;
Thanks for the PR. I guess we could also change the type of ConnectivityMap for all platforms, no? |
@NikolausDemmel updated. Not sure is it will compile normally on Linux. |
Thanks for the update. I think removing the a aligning allocator is problematic. It doesn't result in a compile time error, but it might result in runtime alignment errors (which can sometimes happen and sometimes not, which makes them hard to track down). What is the compilation error with the ConnectivityMap as is? |
Also, which version of OS X and which compiler? |
AppleClang 9.0.0.9000037, Mac OS Siera 10.12.6 |
After downgrade to |
Hm... still curious about why more recent clang chokes on the allocator. But I'll merge for now. Thanks for iterating on this! |
else() | ||
set(BOOST_THREAD_LIBRARY boost_thread) | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S.: Just for the record, I noticed that cmake provides this as Boost_THREAD_LIBRARY
, so we could have just used that... I will correct this at some point.
fix #26
Also I have problem with code compile. Fixed by changing type of
connectivityMap
to: