add basePath to GenApiClient #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejainece
requested changes
Aug 29, 2018
| @@ -2,5 +2,6 @@ export 'requests.dart'; | |||
| export 'params.dart'; | |||
|
|
|||
| class GenApiClient { | |||
| const GenApiClient(); | |||
| final String basePath; | |||
| @@ -2,5 +2,6 @@ export 'requests.dart'; | |||
| export 'params.dart'; | |||
|
|
|||
| class GenApiClient { | |||
| const GenApiClient(); | |||
| final String basePath; | |||
| const GenApiClient([this.basePath = ""]); | |||
There was a problem hiding this comment.
Please make basePath named optional argument.
There was a problem hiding this comment.
Do you mean just initialize it to null instead ?
retrofit_gen/lib/writer/writer.dart
Outdated
| @@ -22,7 +22,7 @@ class Writer { | |||
|
|
|||
| sb.write('var req = base.${r.method}'); | |||
|
|
|||
| if (r.path != null) sb.write('.path("${r.path}")'); | |||
| if (r.path != null) sb.write('.path("\$basePath${r.path}")'); | |||
There was a problem hiding this comment.
Use two different calls to .path method. That way, Jaguar Resty will take care of missing forward slashes, etc.
|
@jaumard Please fix the merge conflicts. |
|
Let me know if there something more to do @tejainece should be ok now |
tejainece
requested changes
Aug 29, 2018
| @@ -2,5 +2,6 @@ export 'requests.dart'; | |||
| export 'params.dart'; | |||
|
|
|||
| class GenApiClient { | |||
| const GenApiClient(); | |||
| final String path; | |||
| const GenApiClient([this.path = null]); | |||
There was a problem hiding this comment.
Please change it to named optional parameter.
const GenApiClient({this.path});
tejainece
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1