-
Notifications
You must be signed in to change notification settings - Fork 374
Update Querying frameworks DataFramesMeta.jl docs #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
reviewed
Oct 18, 2021
bkamins
reviewed
Oct 18, 2021
bkamins
reviewed
Oct 18, 2021
bkamins
reviewed
Oct 18, 2021
bkamins
reviewed
Oct 18, 2021
I think it is OK to mix things here (we should say that these are only some exemplary queries). I have some comments. Thank you! |
nalimilan
approved these changes
Oct 19, 2021
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Thank you! |
Ah sorry for not getting back to this! Thank you for finishing up. |
Sign up for
6E8F
free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2910
I'm a bit inconsistent with
@subset
and@rsubset
. Sometimes I usebegin...end
instead of keyword-argument notation. But I don't want to give too much detail. Let me know what is most natural for new users.