8000 feat: move lws controller replicas to global values by Whitea029 · Pull Request #358 · InftyAI/llmaz · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: move lws controller replicas to global values #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

feat: move lws controller replicas to global values #358

merged 1 commit into from
Apr 22, 2025

Conversation

Whitea029
Copy link
Contributor

What this PR does / why we need it

move lws controller replicas to global values

Which issue(s) this PR fixes

Fixes #348

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 22, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet April 22, 2025 01:11
kerthcet
kerthcet reviewed Apr 22, 2025
View reviewed changes
Copy link
Member
@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit, thanks!

@kerthcet
Copy link
Member

/kind cleanup

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 22, 2025
@kerthcet
Copy link
Member

Seems you need to rebase the code @Whitea029

@Whitea029 Whitea029 force-pushed the move_lws_controller_replicas_to_values branch from d14e2d6 to b27fec1 Compare April 22, 2025 03:48
@Whitea029
Copy link
Contributor Author

OK, it has been rebased to the latest version

@kerthcet
Copy link
Member

/lgtm
/approve

Welcome on board!

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2025
@InftyAI-Agent InftyAI-Agent merged commit b58e605 into InftyAI:main Apr 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce the default lws replicas to 1
3 participants
@Whitea029 @kerthcet @InftyAI-Agent
0