10000 cleanup: upgrade e2e test tools by nayihz · Pull Request #296 · InftyAI/llmaz · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cleanup: upgrade e2e test tools #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

cleanup: upgrade e2e test tools #296

merged 1 commit into from
Mar 10, 2025

Conversation

nayihz
Copy link
Contributor
@nayihz nayihz commented Mar 10, 2025

What this PR does / why we need it

Raised at kubernetes-sigs/kind#3748.
By the way, upgrade the versions of other dependent tools.

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 10, 2025
@nayihz
Copy link
Contributor Author
nayihz commented Mar 10, 2025

/kind cleanup
/assign @kerthcet

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 10, 2025
@kerthcet
Copy link
Member

Can you fix the test first?

@nayihz nayihz force-pushed the upgrade_e2e_tool branch from cc5c325 to 067bc5c Compare March 10, 2025 05:47
@nayihz
Copy link
Contributor Author
nayihz commented Mar 10, 2025

/retest

@nayihz
Copy link
Contributor Author
nayihz commented Mar 10, 2025 •
edited
Loading

Can't reproduce it in my test environment. I'm not sure if the error is caused by insufficient CPU/memory resources of the CI virtual machine. @kerthcet

googs1025
googs1025 reviewed Mar 10, 2025
View reviewed changes
Makefile
@@ -1,8 +1,8 @@
include Makefile-deps.mk

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.28.3
ENVTEST_LWS_VERSION = v0.4.0
ENVTEST_K8S_VERSION = 1.32.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be v1.32.2 is better?
Also do we need to see the kind version? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest setup-envtest binary doesn't support 1.32.2.

./bin/setup-envtest use
Version: 1.32.0
OS/Arch: linux/amd64
sha512: 3a9584af30d041c42893d8f7a860aa434976d4aee479cf2e9a50a9e5677dcc83d3012a2146a6feb5b2e95a7b3c6f657ae9c591745981262da8b06e4b61dcdf17
Path: /home/codespace/.local/share/kubebuilder-envtest/k8s/1.32.0-linux-amd64

Copy link
Member
@googs1025 googs1025 Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got this.

@kerthcet
Copy link
Member

/retest

@kerthcet
Copy link
Member

retest works now with #302 supports.

@kerthcet
Copy link
Member

Can't reproduce it in my test environment. I'm not sure if the error is caused by insufficient CPU/memory resources of the CI virtual machine

This usually happens because of the model downloading too slow. Let me check.

@kerthcet
Copy link
Member

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2025
@kerthcet
Copy link
Member

/triage accepted

@InftyAI-Agent InftyAI-Agent added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a label and requires one. labels Mar 10, 2025
@InftyAI-Agent InftyAI-Agent merged commit b9012d8 into InftyAI:main Mar 10, 2025
27 of 29 checks passed
@kerthcet
Copy link
Member

/triage accepted

Just to trigger the workflow again.

@nayihz nayihz deleted the upgrade_e2e_tool branch March 10, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 left review comments

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Non 459D e yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nayihz @kerthcet @googs1025 @InftyAI-Agent
0