feature: add some field for OpenModel Playground Service #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind feature |
|
test locally: display like this root@VM-0-3-ubuntu:/home/ubuntu# kubectl get isvc
NAME NAME REPLICAS STATUS AGE
opt-125m opt-125m 1 27m
qwen2-0--5b qwen2-0--5b 1 ServiceReady 28m
root@VM-0-3-ubuntu:/home/ubuntu# kubectl get pl
NAME MODEL REPLICAS STATUS AGE
opt-125m opt-125m 1 27m
qwen2-0--5b qwen2-0--5b 1 PlaygroundReady 28m
root@VM-0-3-ubuntu:/home/ubuntu#
root@VM-0-3-ubuntu:/home/ubuntu#
root@VM-0-3-ubuntu:/home/ubuntu# kubectl get om
NAME MODELHUB MODELID OWNEDBY AGE
opt-125m Huggingface facebook/opt-125m llmaz 30m
qwen2-0--5b llmaz 30m |
kerthcet
reviewed
Jun 18, 2025
| @@ -228,6 +228,10 @@ type ModelStatus struct { | |||
| //+kubebuilder:object:root=true | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:resource:shortName=om,scope=Cluster | |||
| //+kubebuilder:printcolumn:name="MODELHUB",type=string,JSONPath=`.spec.source.modelHub.name`,description="Model hub name" | |||
| //+kubebuilder:printcolumn:name="MODELID",type=string,JSONPath=`.spec.source.modelHub.modelID`,description="Model ID on the model hub" | |||
There was a problem hiding this comment.
what if the modelhub and modelid is not present, for example, we use s3 as the model source.
There was a problem hiding this comment.
root@VM-0-3-ubuntu:/home/ubuntu/llmaz# kubectl get om
NAME OWNEDBY AGE MODELHUB MODELID URI
opt-125m llmaz 4h48m Huggingface facebook/opt-125m
qwen2-0--5b llmaz 4h48m ollama://qwen2:0.5b
qwen2-7b llmaz 17m oss://llmaz.oss-ap-southeast-1-internal.aliyuncs.com/models/Qwen2-7B
Indeed, I currently changed it to: as follows,
But I am not sure if it is a good way.
There was a problem hiding this comment.
Reasonable to me, maybe we should define it as hf://, but can't fully compatible with us today.
Can we make it N/A if no value?
There was a problem hiding this comment.
Without changing the original code logic (for example, changing the unset field to N/A), it seems that printcolumn feature provided by kubebuilder can't work. 🤔
fbaea2c to
3a98c29
Compare
Signed-off-by: googs1025 <googs1025@gmail.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes None
Special notes for your reviewer
Does this PR introduce a user-facing change?