feat: support configuring init container image #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70861f4 to
621c32d
Compare
|
/kind feature Will continue the review work later. |
8000
kerthcet
reviewed
Jun 13, 2025
|
we need to solve the conflicts first. |
|
@kerthcet Got it. I'll fix the conflicts first and then complement the related unit tests. |
bce4990 to
8ea73a9
Compare
Signed-off-by: rudeigerc <rudeigerc@gmail.com>
8ea73a9 to
37925eb
Compare
googs1025
reviewed
Jun 18, 2025
| @@ -72,6 +72,22 @@ func ValidateService(ctx context.Context, k8sClient client.Client, service *infe | |||
| models = append(models, model) | |||
| } | |||
|
|
|||
| // Fetch global configuration. | |||
There was a problem hiding this comment.
in line 117
we already have:
if err := ValidateConfigmap(ctx, k8sClient, service); err != nil {
return err
}Is this not enough or can we merge?
There was a problem hiding this comment.
Let's move to the ValidateConfigmap
kerthcet
reviewed
Jun 18, 2025
| initContainerName := MODEL_LOADER_CONTAINER_NAME | ||
| if index != 0 { | ||
| initContainerName += "-" + strconv.Itoa(index) | ||
| } | ||
|
|
||
| if initContainerImage == "" { | ||
| initContainerImage = pkg.LOADER_IMAGE |
There was a problem hiding this comment.
I think, we can totally remove the LOADER_IMAGE in the follow up. The configmap is the single source of truth.
| @@ -72,6 +72,22 @@ func ValidateService(ctx context.Context, k8sClient client.Client, service *infe | |||
| models = append(models, model) | |||
| } | |||
|
|
|||
| // Fetch global configuration. | |||
There was a problem hiding this comment.
Let's move to the ValidateConfigmap
|
@rudeigerc any updated? |
|
@googs1025 Thanks for the reminder. I am out of bandwidth recently, but I will try to make an update this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull request supports configuring the init container image via
init-container-imageinconfig.data.Which issue(s) this PR fixes
Closes #350
Special notes for your reviewer
Please note that only integration tests have been implemented. I think unit tests could be appended after #434 is merged.
Does this PR introduce a user-facing change?