8000 use lws as sub chart by carlory · Pull Request #408 · InftyAI/llmaz · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use lws as sub chart #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

use lws as sub chart #408

merged 1 commit into from
May 9, 2025

Conversation

carlory
Copy link
Member
@carlory carlory commented May 9, 2025

What this PR does / why we need it

Fix the webhook of lws do not work when the lws is deployed in the llmaz-system using make helm-install because the webhook service selector selects the wrong pod.

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

Fix the webhook of lws do not work when the lws is deployed in the llmaz-system using make helm-install because the webhook service selector selects the wrong pod.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 9, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet May 9, 2025 10:45
@carlory
Copy link
Member Author
carlory commented May 9, 2025

/kind bug
/kind documentation

@InftyAI-Agent InftyAI-Agent added bug Categorizes issue or PR as related to a bug. documentation Categorizes issue or PR as related to documentation. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 9, 2025
@carlory
Copy link
Member Author
carlory commented May 9, 2025

related to #354

kerthcet
kerthcet reviewed May 9, 2025
View reviewed changes
Copy link
Member
@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this lead to lws installed in lws-system?

@carlory
Copy link
Member Author
carlory commented May 9, 2025

Test result:

(base) ➜  llmaz git:(use-lws-chart) KIND_CLUSTER_NAME=kind2 make helm-install
test -s /Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/controller-gen && /Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/controller-gen --version | grep -q v0.16.1 || \
	GOBIN=/Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.1
/Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/controller-gen \
		rbac:roleName=manager-role output:rbac:artifacts:config=config/rbac \
		crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/crd/bases \
		webhook output:webhook:artifacts:config=config/webhook \
		paths="./..."
test -s /Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/helmify || GOBIN=/Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin go install github.com/arttor/helmify/cmd/helmify@v0.4.18
/Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/kustomize build config/default | /Users/kiki/workspace/golang/src/github.com/inftyai/llmaz/bin/helmify -crd-dir
INFO[0000] Chart name is not set. Using default name 'chart
helm upgrade --namespace llmaz-system --install llmaz ./chart -f ./chart/values.global.yaml --dependency-update --create-namespace
Release "llmaz" does not exist. Installing it now.
NAME: llmaz
LAST DEPLOYED: Fri May  9 18:49:48 2025
NAMESPACE: llmaz-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
(base) ➜  llmaz git:(use-lws-chart) kubectl get ns
NAME                    STATUS   AGE
default                 Active   36m
kube-node-lease         Active   36m
kube-prometheus-stack   Active   12m
kube-public             Active   36m
kube-system             Active   36m
llmaz-system            Active   49s
local-path-storage      Active   36m
(base) ➜  llmaz git:(use-lws-chart) helm ls -A
NAME                 	NAMESPACE            	REVISION	UPDATED                             	STATUS  	CHART                       	APP VERSION
kube-prometheus-stack	kube-prometheus-stack	1       	2025-05-09 18:48:11.841675 +0800 CST	deployed	kube-prometheus-stack-72.2.0	v0.82.0
llmaz                	llmaz-system         	1       	2025-05-09 18:49:48.232756 +0800 CST	deployed	llmaz-0.0.9                 	0.1.3
(base) ➜  llmaz git:(use-lws-chart) kubectl -n llmaz-system get po
NAME                                           READY   STATUS              RESTARTS   AGE
ai-gateway-controller-5b7c5f4898-prdvj         0/1     ContainerCreating   0          40s
envoy-gateway-649fb567cc-2brtm                 0/1     ContainerCreating   0          40s
llmaz-controller-manager-f69489479-tbrkt       0/1     ContainerCreating   0          40s
llmaz-lws-controller-manager-b4c9df475-zgld2   0/1     ContainerCreating   0          40s
open-webui-66d8b668b8-jkjnh                    0/1     Init:0/1            0          40s
prometheus-llmaz-prometheus-0                  0/2     Init:0/1            0          40s

@carlory
use lws as sub chart
7d54827 
Signed-off-by: carlory <baofa.fan@daocloud.io>
@kerthcet
Copy link
Member
kerthcet commented May 9, 2025

/lgtm
/approve
/kind cleanup
/remove-kind bug
/remove-kind documentation

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed bug Categorizes issue or PR as related to a bug. documentation Categorizes issue or PR as related to documentation. labels May 9, 2025
@kerthcet
Copy link
Member
kerthcet commented May 9, 2025

/retest

@InftyAI-Agent InftyAI-Agent merged commit e72f7da into InftyAI:main May 9, 2025
36 of 42 checks passed
@carlory carlory deleted the use-lws-chart branch May 11, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlory @kerthcet @InftyAI-Agent
0