8000 Add Dalli.close support to the storage adapter for use in process forking by joellarsonibotta · Pull Request #41 · Ibotta/atomic_cache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Dalli.close support to the storage adapter for use in process forking #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Dalli.close support to the storage adapter for use in process forking #41

wants to merge 1 commit into from

Conversation

joellarsonibotta
Copy link

Background

This change adds a delegation to Dalli.close for the Dalli storage adapter. It is useful when trying to clear Dalli connections when forking a process.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@joellarsonibotta joellarsonibotta force-pushed the feature/delegate-close-to-dalli-client branch from 375cc62 to c1c96f1 Compare December 23, 2021 21:11
lebeerman
lebeerman approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor
@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to do - not sure if adding example usage for why this would be necessary would benefit future gem users.

@lebeerman
Copy link
Contributor

Only other item here - probably want to bump the version to kick off the deploy:

https://github.com/Ibotta/atomic_cache/blob/main/lib/atomic_cache/version.rb#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyxraven onyxraven onyxraven approved these changes

@lebeerman lebeerman lebeerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joellarsonibotta @lebeerman @onyxraven
0