Fix python-publish GitHub workflow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub workflows don't seem to work on `release` with type `created`, see e.g. ISA-tools/isa-api@f86e8b4 - Split the building and uploading of packages so that we build packages for every push and pull request. - Use the `build` package instead of `setup.py` to build the sdist and wheel packages. - Use the `pypi-publish` action instead of twine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isa-rwval 0.10.11 packages weren't uploaded to PyPI because the python-publish workflow didn't run.
GitHub workflows don't seem to work on
releasewith typecreated, see e.g. ISA-tools/isa-api@f86e8b4buildpackage instead ofsetup.pyto build the sdist and wheel packages.pypi-publishaction instead of twine.