8000 Fix compilation issues + add FFT warmup function by s-mayani · Pull Request #253 · IPPL-framework/ippl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix compilation issues + add FFT warmup function #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 12, 2024
Merged

Fix compilation issues + add FFT warmup function #253

merged 6 commits into from
Jan 12, 2024

Conversation

s-mayani
Copy link
Collaborator

This PR addresses the following:

  • Compilation issues in test/FFT/TestCos1.cpp and in FFTOpenPoissonSolver.hpp after previous merge, due to some conflicts with changes in Communicate.
  • Add a warmup() function in the FFT class which performs a dummy FORWARD and BACKWARD transform. Calling this will always ensure that the warmup step is done for both directions, which when not done causes performance issues.
  • Add a comment explaining the windowing of the Green's function in the Vico-Greengard solver.
  • Remove all MPI Barriers from FFTOpenPoissonSolver.hpp, which were unnecessary and causing slowdown.

@s-mayani s-mayani added bug Something isn't working feature request Used to label a feature request in the issue tracker. labels Jan 12, 2024
@s-mayani s-mayani self-assigned this Jan 12, 2024
@s-mayani s-mayani linked an issue Jan 12, 2024 that may be closed by this pull request
Warmup method in FFT class #234
Closed
matt-frey
matt-frey approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member
@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@s-mayani s-mayani merged commit 8967b6e into IPPL-framework:dev-3.2.0 Jan 12, 2024
@s-mayani s-mayani deleted the fft_warmup branch January 12, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikrrish srikrrish srikrrish approved these changes

@matt-frey matt-frey matt-frey approved these changes

Assignees

@s-mayani s-mayani

Labels
bug Something isn't working feature request Used to label a feature request in the issue tracker.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warmup method in FFT class
3 participants
@s-mayani @srikrrish @matt-frey
0