8000 121 vico greengard discrete cosine transforms by vmontanaro · Pull Request #231 · IPPL-framework/ippl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

121 vico greengard discrete cosine transforms #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 66 commits into from
Jan 12, 2024
Merged

121 vico greengard discrete cosine transforms #231

merged 66 commits into from
Jan 12, 2024

Conversation

vmontanaro
Copy link
Contributor

No description provided.

s-mayani and others added 30 commits July 25, 2022 10:34
@s-mayani
add attributes for 2N+1 green's function implementation for improved VG
f56e84e
@s-mayani
add initialization of new 2N+1 grid and fft objects
353f88c
@s-mayani
merge master - fix indentation issues
e1fe84b
@s-mayani
add warmup step for 2N+1 FFT object
33d9c0e
@s-mayani
initial implementation of the 2N+1 green's function - added a new alg…
05a74da 
… flag: VICO_2.0
@s-mayani
fix compilation issues
944dc40
@s-mayani
results are wrong, debugging and testing ongoing
442d027
@s-mayani
forgot scaling factor
07d41e2
@s-mayani
Merge remote-tracking branch 'origin/master' into 121-vico-greengard-…
2047608 
…discrete-cosine-transforms
@s-mayani
some print statements for debugging
8d43487
@s-mayani
fixed bug in scaling of green's function, removed some print statements
0c62f8d
@s-mayani
merge master into branch + resolve conflicts
2874661
@s-mayani
merge master - new ippl init; resolve conflicts
bdded60
@s-mayani
change some mdrange_types to ippl::getRangePolicy
6c5e22a
@s-mayani
merge master
ab12d53
Fixed normalization constants to match heFFTe's DCT-I
3ae6810
Merge branch 'master' into 121-vico-greengard-discrete-cosine-transforms
923e9b3 
merge master into 121-vico-greengard-discrete-cosine-transforms
Added line for Cos1 in CMakeLists.txt
68614e6
@Arc676
Add common superclass for FFT
55f800d 
Share heffte type aliases and members
@Arc676
Move field layout alias to FFT superclass
e29cfe6
@Arc676
Move shared FFT code to shared base class
dd11efd
@Arc676
Reuse temporary FFT fields
9b7b484
@Arc676
Skip solver reinitialization if domain is unchanged
b49fe4e
@Arc676
Fix constructor inheritance
b02dcb4
@Arc676
Add memory space to shrunk view type
79475f9
@Arc676
Inherit execution space for FFT output field
929c04f
Fixed unmerged line
2a7b72f
@Arc676
Use enum for FFTs and fix type uniformity
466c8d2 
Define uniform type for fields
Fix mixed execution FFTs
Define enum to identify forward and backward FFTs
Merged with master
324d735
Merge remote-tracking branch 'alex_ippl/fft-optimizations' into 121-v…
9c1bb71 
…ico-greengard-discrete-cosine-transforms
Merge branch '121-vico-greengard-discrete-cosine-transforms' of githu…
051bc8a 
…b.com:vmontanaro/ippl into 121-vico-greengard-discrete-cosine-transforms

Conflicts:
	test/solver/TestGaussian.cpp
s-mayani
s-mayani requested changes Nov 3, 2023
View reviewed changes
@vmontanaro vmontanaro changed the base branch from master to dev-3.2.0 November 8, 2023 08:59
matt-frey
matt-frey requested changes Nov 8, 2023
View reviewed changes
Copy link
Member
@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a brief look at the code. I think there are many improvements and changes necessary. Some lines of code are duplicated.

@srikrrish srikrrish added enhancement New feature or request feature request Used to label a feature request in the issue tracker. and removed enhancement New feature or request labels Nov 15, 2023
aaadelmann
aaadelmann requested changes Nov 22, 2023
View reviewed changes
matt-frey
matt-frey requested changes Dec 5, 2023
View reviewed changes
Copy link
Member
@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few things to change.

src/PoissonSolvers/FFTOpenPoissonSolver.hpp Outdated
// compute length of the physical domain
// compute Fourier domain spacing
for (unsigned int i = 0; i < Dim; ++i) {
hs_m[i] = pi * 0.5 / l[i];
Copy link
Member
@matt-frey matt-frey Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kokkos::pi

src/FFT/FFT.hpp Outdated
*This copy to a temporary Kokkos view is needed because of following
*reasons:
*1) heffte wants the input and output fields without ghost layers
*2) heffte accepts data in layout left (by default) eventhough this
Copy link
Member
@matt-frey matt-frey Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventhough -- > even though

@vmontanaro vmontanaro merged commit 1524b0b into IPPL-framework:dev-3.2.0 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-mayani s-mayani s-mayani approved these changes

@aaadelmann aaadelmann aaadelmann approved these changes

@matt-frey matt-frey matt-frey approved these changes

Assignees

@vmontanaro vmontanaro

Labels
feature request Used to label a feature request in the issue tracker.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vmontanaro @aaadelmann @matt-frey @s-mayani @srikrrish @Arc676
0