8000 Support constants in `DependencyOrder` cop. by reitermarkus · Pull Request #4327 · Homebrew/brew · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support constants in DependencyOrder cop. #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2018
Merged

Support constants in DependencyOrder cop. #4327

merged 2 commits into from
Jun 11, 2018

Conversation

reitermarkus
Copy link
Member
@reitermarkus reitermarkus commented Jun 11, 2018 •
edited
Loading
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/homebrew-core#28873.

@ghost ghost assigned reitermarkus Jun 11, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 11, 2018
@reitermarkus reitermarkus force-pushed the dependency-order-cop branch 2 times, most recently from d6221e5 to c5c4f04 Compare June 11, 2018 02:23
@reitermarkus reitermarkus force-pushed the dependency-order-cop branch from c5c4f04 to b9ba631 Compare June 11, 2018 02:24
@reitermarkus reitermarkus requested a review from GauthamGoli June 11, 2018 02:25
@MikeMcQuaid MikeMcQuaid merged commit 3081390 into Homebrew:master Jun 11, 2018
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@ghost ghost removed the in progress Maintainers are working on this label Jun 11, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 11, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
@reitermarkus reitermarkus deleted the dependency-order-cop branch July 12, 2018 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@GauthamGoli GauthamGoli Awaiting requested review from GauthamGoli

Assignees

@reitermarkus reitermarkus

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @MikeMcQuaid
0