8000 Fix `MissingFormula` namespacing. by reitermarkus · Pull Request #4104 · Homebrew/brew · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix MissingFormula namespacing. #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2018
Merged

Fix MissingFormula namespacing. #4104

merged 1 commit into from
Apr 22, 2018

Conversation

reitermarkus
Copy link
Member
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Refs #4068 (comment).

Closes #4103.

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Apr 22, 2018
@ilovezfs
Copy link
Contributor

What's with all the whitespace change?

@reitermarkus
Copy link
Member Author

That was basically my argument here: #4068 (comment)

It's either removing module Homebrew from MissingFormula or adding it to everything else.

@MikeMcQuaid MikeMcQuaid merged commit 648a7c7 into Homebrew:master Apr 22, 2018
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Apr 22, 2018
@reitermarkus reitermarkus deleted the missing-formula branch April 22, 2018 18:27
@lock lock bot added the outdated PR was locked due to age label May 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reitermarkus @ilovezfs @MikeMcQuaid @BrewTestBot
0