8000 Warlock APLs by syrifgit · Pull Request #4847 · Hekili/hekili · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warlock APLs #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: thewarwithin
Choose a base branch
from
Open

Warlock APLs #4847

wants to merge 2 commits into from

Conversation

syrifgit
Copy link
Collaborator
@syrifgit syrifgit commented May 6, 2025

All 3 brought up to date with their respective SimC APLs. Have a look over and make sure I haven't undone anything custom, these are my least familiar APLs.

@Hekili
Copy link
Owner
Hekili commented May 7, 2025

I think the active_dot.corruption=0 and similar checks for Affliction are tailored to the addon; essentially, it is meant to deal with packs of enemies dying quickly. We also don't want to apply Corruption while Seed of Corruption is in-flight.

@syrifgit
Copy link
Collaborator Author
syrifgit commented May 8, 2025

@Hekili updated to remove affliction, idk when I will have time to do it as I'm travelling again this weekend. Can proceed with PR to do destro/demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0