Don't round camera position on sync #1243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Iirc that rounding was added in order to avoid pixel bleeding during rendering, but it's been 4 years and I don't remember exactly. I would say gate it behind |
|
Is this fine for merge? We could also check for heaps_h2d_enable_camera_rounding!=false to have the default behaviour (without a define) to not round. |
|
|
I have made adjustments. Would this be suitable for merge? |
|
Removed duplicate code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a 2D game where the camera continually moves around, and the fact that the camera rounds its position leads to stuttering.
This change fixes the issue for me, but I also think it is good default behavior to have sub-pixel precision on the camera by default. Maybe I am wrong though? Maybe making this configurable would be better?